Repository navigation
KF-33 add tests for ThreadPool - #74
Merged
Merged
Conversation
Kellesi
force-pushed
the
KF-33-test-ThreadPool
branch
2 times, most recently
from
August 20, 2025 17:45
a45fd64 to
2a2e108
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the kf::ThreadPool class to address ticket KF-33. The tests verify core ThreadPool functionality including thread creation, execution, cleanup, and move semantics.
- Adds test scenarios for normal operation, boundary conditions, and move semantics
- Includes precompiled header updates with C++ runtime helper functions for kernel-mode testing
- Fixes uninitialized array issue in ThreadPool header
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/ThreadPoolTest.cpp | New comprehensive test suite covering ThreadPool functionality with various scenarios |
| test/pch.h | Adds C++ runtime helper functions needed for kernel-mode testing environment |
| test/CMakeLists.txt | Includes the new ThreadPoolTest.cpp in the build configuration |
| include/kf/ThreadPool.h | Initializes m_threads array to prevent undefined behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SergiusTheBest
force-pushed
the
KF-33-test-ThreadPool
branch
from
October 15, 2026 13:50
a1ec155 to
3660ad2
Compare
SergiusTheBest
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-33