Skip to content

CI: add Vista SP2 PE compatibility gate for built driver artifacts - #98

Merged
SergiusTheBest merged 3 commits into
mainfrom
copilot/add-validation-step-ci
Aug 14, 2026
Merged

CI: add Vista SP2 PE compatibility gate for built driver artifacts#98
SergiusTheBest merged 3 commits into
mainfrom
copilot/add-validation-step-ci

Conversation

Copilot AI commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds a CI validation stage to ensure produced Windows driver binaries remain compatible with the Vista SP2 API baseline. It introduces a post-build PE import compatibility check in the existing workflow.

  • What changed

    • Added a new step in .github/workflows/ci.yml after the build step to run pecompatcheck-action against the built driver artifact:
      • build/test/${{ matrix.config }}/kf-test.sys
      • target baseline: vista-sp2

  • Supply-chain hardening

    • Pinned SergiusTheBest/pecompatcheck-action to an immutable commit SHA instead of a floating tag.

  • Workflow behavior impact

    • CI now fails when the built .sys imports symbols unavailable on Vista SP2, preventing incompatible binaries from passing the pipeline.
- name: Validate Vista SP2 compatibility
  uses: sergiusthebest/pecompatcheck-action@0ac779e953508f7ef968af9ec1c4d99ce59202d7 # v1
  with:
    binary: build/test/${{ matrix.config }}/kf-test.sys
    windows-version: vista-sp2

Copilot AI linked an issue Aug 14, 2026 that may be closed by this pull request
Add validation step to CI #97
Closed
Copilot AI and others added 2 commits August 14, 2026 08:47
@SergiusTheBest
Add Vista SP2 compatibility validation to CI
83e226d 
Co-authored-by: SergiusTheBest <4660722+SergiusTheBest@users.noreply.github.com>
@SergiusTheBest
Pin PECompatCheck action to immutable SHA
68a043b 
Co-authored-by: SergiusTheBest <4660722+SergiusTheBest@users.noreply.github.com>
Copilot AI changed the title [WIP] Add validation step to CI CI: add Vista SP2 PE compatibility gate for built driver artifacts Aug 14, 2026
Copilot AI requested a review from SergiusTheBest August 14, 2026 08:49
@SergiusTheBest
SergiusTheBest marked this pull request as ready for review August 14, 2026 09:14
@SergiusTheBest
SergiusTheBest merged commit e5215d9 into main Aug 14, 2026
8 of 20 checks passed
@SergiusTheBest
SergiusTheBest deleted the copilot/add-validation-step-ci branch August 14, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SergiusTheBest SergiusTheBest SergiusTheBest approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@SergiusTheBest SergiusTheBest

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add validation step to CI

2 participants

@SergiusTheBest