Skip to content

chore: bump to pyo3 0.29 - #199

Open
cimandef wants to merge 3 commits into
mainfrom
angel/upgrade_py03
Open

chore: bump to pyo3 0.29#199
cimandef wants to merge 3 commits into
mainfrom
angel/upgrade_py03

Conversation

@cimandef

@cimandef cimandef commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

depends on: PyO3/pyo3-async-runtimes#85

Summary by CodeRabbit

  • Chores
    • Updated Python bindings dependencies to newer versions across project configuration files, including async runtime integration.
  • Refactor
    • Updated Python version detection for version reporting to rely on a static version string.
    • Aligned CLI telemetry’s Python runtime context to use the same static Python version string for consistency.

@cimandef cimandef self-assigned this Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@cimandef, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 61dd6add-19c7-40a7-852a-31f906168baa

📥 Commits

Reviewing files that changed from the base of the PR and between 1f454d9 and e271161.

📒 Files selected for processing (2)
  • Cargo.toml
  • runner/Cargo.toml
📝 Walkthrough

Walkthrough

This PR upgrades pyo3 and pyo3-async-runtimes from 0.28 to 0.29 in the root and runner manifests, and updates Python version retrieval in telemetry and version code to use Python::version_str().

Changes

pyo3 0.28 to 0.29 Upgrade

Layer / File(s) Summary
Dependency version updates
Cargo.toml, runner/Cargo.toml
pyo3 and pyo3-async-runtimes are bumped from 0.28 to 0.29 in both manifests, with existing features retained.
Python version string retrieval migration
src/commands/version.rs, src/commands/mod.rs
PYTHON_VERSION and Sentry runtime_context initialization switch from Python::attach-based version lookup to Python::version_str().

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jpopesculian

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading PyO3 to 0.29.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch angel/upgrade_py03

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Cargo.toml`:
- Line 137: Replace the moving branch pin for the pyo3-async-runtimes dependency
with the exact commit SHA to ensure deterministic lockfiles: locate the
pyo3-async-runtimes dependency entry (the line with pyo3-async-runtimes and
branch = "angel/bump_pyo3_version") and change it to use rev =
"9c609defa70a2f9f7f3c407bff7696ba628e065d" instead of branch so Cargo.lock
refreshes remain stable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 225c94db-c980-46e2-9660-bb47ec09bb45

📥 Commits

Reviewing files that changed from the base of the PR and between 8736106 and cf55583.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • runner/Cargo.toml
  • src/commands/mod.rs
  • src/commands/version.rs

Comment thread Cargo.toml Outdated
@cimandef
cimandef force-pushed the angel/upgrade_py03 branch from cf55583 to a7044ae Compare June 15, 2026 09:07
@cimandef
cimandef requested a review from jpopesculian June 15, 2026 09:11
@cimandef
cimandef force-pushed the angel/upgrade_py03 branch 2 times, most recently from c3e1076 to 1f454d9 Compare July 23, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant