feat(template): indexer-owned .ignore and a .secrets example for work… - #208
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe scaffolds add ChangesScaffold template updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@template/assets/workspace/.secrets.hbs`:
- Around line 1-12: Block release until aqora-io/kubimo#56 is merged and
deployed. Update docker/Dockerfile.kubimo to consume an image containing the
.secrets indexer support, then verify archive, file-listing, clone, and
names-only restore behavior for both templates.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 24c44ada-10c6-4025-9bf4-bb75790f12a4
📒 Files selected for processing (6)
template/assets/dataset_marimo/.secrets.hbstemplate/assets/workspace/.gitignore.hbstemplate/assets/workspace/.ignore.hbstemplate/assets/workspace/.secrets.hbstemplate/src/dataset_marimo.rstemplate/src/workspace.rs
💤 Files with no reviewable changes (1)
- template/assets/workspace/.gitignore.hbs
…spaces The hosted workspace template's exclusion file is now .ignore instead of .gitignore: a hosted workspace has no git, the kubimo indexer honours .ignore natively, and the rename keeps the indexer-owned dotfiles (.ignore, .secrets, .env) distinct from git functionality. Both workspace templates also ship a comments-only .secrets explaining the secrets side-channel: matched files stay out of the archive and file listings and are restored only into clones allowed to see them, while .env - where marimo's Secrets panel writes - is always secret, with public clones receiving name-only placeholders. dataset_marimo keeps its .gitignore: that scaffold is dual-use, and an 'aqora new dataset-marimo' on a user's own machine needs git hygiene; the hosted indexer honours .gitignore just the same.
7219091 to
5ac1bbf
Compare
Kubimo aqora-io/kubimo#56 should be merged in first
Summary by CodeRabbit
New Features
Bug Fixes
.ignoreand.secretswhile removing.gitignore..gitignoresupport for dataset scaffolds.