Skip to content

feat(template): indexer-owned .ignore and a .secrets example for work… - #208

Merged
jpopesculian merged 1 commit into
mainfrom
jpop/ignore-secrets
Aug 12, 2026
Merged

feat(template): indexer-owned .ignore and a .secrets example for work…#208
jpopesculian merged 1 commit into
mainfrom
jpop/ignore-secrets

Conversation

@jpopesculian

@jpopesculian jpopesculian commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Kubimo aqora-io/kubimo#56 should be merged in first

Summary by CodeRabbit

  • New Features

    • Added guidance and templates for managing secret files and environment variables.
    • Added workspace archive ignore rules covering generated files, virtual environments, application state, and metadata.
    • Documented how ignored and secret files behave during syncing, cloning, restoring, and backups.
  • Bug Fixes

    • Updated generated workspace scaffolding to include .ignore and .secrets while removing .gitignore.
    • Preserved .gitignore support for dataset scaffolds.
    • Ensured generated secret files contain only comments or blank lines by default.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c52d483-e6b5-4338-921e-d542403dd74f

📥 Commits

Reviewing files that changed from the base of the PR and between 7219091 and 5ac1bbf.

📒 Files selected for processing (1)
  • template/src/workspace.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • template/src/workspace.rs

📝 Walkthrough

Walkthrough

The scaffolds add .ignore and .secrets templates, remove workspace .gitignore expectations, and document secret-file handling. Rendering tests verify the generated files and their contents.

Changes

Scaffold template updates

Layer / File(s) Summary
Ignore and secret template definitions
template/assets/dataset_marimo/.secrets.hbs, template/assets/workspace/.ignore.hbs, template/assets/workspace/.secrets.hbs
Dataset-marimo and workspace scaffolds document secret patterns. Workspace archives ignore generated files, virtual environments, Marimo state, and aqora metadata.
Generated scaffold validation
template/src/dataset_marimo.rs, template/src/workspace.rs
Rendering tests verify .secrets, .ignore, and .gitignore expectations. They also check comments-only secrets and .venv exclusion.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • aqora-io/cli#205: Introduced the workspace and dataset-marimo scaffolding extended by this change.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main template changes: an indexer-owned .ignore file and a .secrets example for workspaces.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jpop/ignore-secrets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@template/assets/workspace/.secrets.hbs`:
- Around line 1-12: Block release until aqora-io/kubimo#56 is merged and
deployed. Update docker/Dockerfile.kubimo to consume an image containing the
.secrets indexer support, then verify archive, file-listing, clone, and
names-only restore behavior for both templates.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 24c44ada-10c6-4025-9bf4-bb75790f12a4

📥 Commits

Reviewing files that changed from the base of the PR and between bb12144 and 7219091.

📒 Files selected for processing (6)
  • template/assets/dataset_marimo/.secrets.hbs
  • template/assets/workspace/.gitignore.hbs
  • template/assets/workspace/.ignore.hbs
  • template/assets/workspace/.secrets.hbs
  • template/src/dataset_marimo.rs
  • template/src/workspace.rs
💤 Files with no reviewable changes (1)
  • template/assets/workspace/.gitignore.hbs

Comment thread template/assets/workspace/.secrets.hbs
…spaces

The hosted workspace template's exclusion file is now .ignore instead of
.gitignore: a hosted workspace has no git, the kubimo indexer honours .ignore
natively, and the rename keeps the indexer-owned dotfiles (.ignore, .secrets,
.env) distinct from git functionality. Both workspace templates also ship a
comments-only .secrets explaining the secrets side-channel: matched files stay
out of the archive and file listings and are restored only into clones allowed
to see them, while .env - where marimo's Secrets panel writes - is always
secret, with public clones receiving name-only placeholders.

dataset_marimo keeps its .gitignore: that scaffold is dual-use, and an
'aqora new dataset-marimo' on a user's own machine needs git hygiene; the
hosted indexer honours .gitignore just the same.
@jpopesculian
jpopesculian merged commit 74dcca3 into main Aug 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant