Skip to content

feat(template): add conda workspace - #209

Merged
volgar1x merged 1 commit into
mainfrom
feat-conda-workspace
Aug 12, 2026
Merged

feat(template): add conda workspace#209
volgar1x merged 1 commit into
mainfrom
feat-conda-workspace

Conversation

@volgar1x

@volgar1x volgar1x commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added support for generating Conda-based workspace templates.
    • Generated workspaces now include a full-width welcome notebook with project metadata and documentation guidance.
    • Workspace templates can be rendered directly to a specified output location.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c270e75-a275-4f83-9da9-f4e51708281b

📥 Commits

Reviewing files that changed from the base of the PR and between bb12144 and c017b28.

📒 Files selected for processing (2)
  • template/assets/conda_workspace/readme.py.hbs
  • template/src/workspace.rs
 _________________________
< Think twice, code once. >
 -------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-conda-workspace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
template/src/workspace.rs (1)

47-49: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Add a regression test for the conda rendering path.

The current tests cover render, but not render_conda. The registry resolves embedded templates by prefix. Verify that the builder creates readme.py with the supplied name and version. This catches missing asset registration or prefix mismatches. (raw.githubusercontent.com)

Suggested regression test
+    #[test]
+    fn renders_conda_readme() {
+        let dir = tempfile::tempdir().unwrap();
+        let out = dir.path().join("conda");
+        WorkspaceTemplate::builder()
+            .name("My Workspace")
+            .slug("my-workspace")
+            .render_conda(&out)
+            .unwrap();
+        let readme = std::fs::read_to_string(out.join("readme.py")).unwrap();
+        assert!(readme.contains("# My Workspace v0.0.0"));
+    }

Also applies to: 82-86

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@template/src/workspace.rs` around lines 47 - 49, Add a regression test
alongside the existing Workspace rendering tests that invokes
Workspace::render_conda with a temporary output directory, then verifies
readme.py exists and contains the supplied name and version. Keep the test
focused on the conda_workspace registry prefix so missing asset registration or
prefix mismatches are detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@template/src/workspace.rs`:
- Around line 47-49: Add a regression test alongside the existing Workspace
rendering tests that invokes Workspace::render_conda with a temporary output
directory, then verifies readme.py exists and contains the supplied name and
version. Keep the test focused on the conda_workspace registry prefix so missing
asset registration or prefix mismatches are detected.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c270e75-a275-4f83-9da9-f4e51708281b

📥 Commits

Reviewing files that changed from the base of the PR and between bb12144 and c017b28.

📒 Files selected for processing (2)
  • template/assets/conda_workspace/readme.py.hbs
  • template/src/workspace.rs

@volgar1x
volgar1x merged commit 514b16d into main Aug 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant