Repository navigation
Feat: Watch Party - #17
Merged
Merged
Conversation
…orkflow job names
…rticipant timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the API documentation (
API.md) and some workflow naming in GitHub Actions to reflect recent API changes and improvements, particularly around upload token handling, public ID usage, and the addition of a new Watch Party feature. The changes clarify and expand API endpoint descriptions, update parameter requirements, and document new functionality for collaborative media viewing. Below are the most important changes grouped by theme:API Documentation Improvements and New Features:
POST /api/tokens/{download_token}/uploads/{upload_id}/watch), deletion (DELETE /api/watch/{room_id}), and WebSocket synchronization (WS /api/watch/{room_id}/ws). These endpoints enable temporary collaborative playback sessions for completed uploads, with detailed authentication, error handling, and protocol descriptions.Parameter and Response Changes:
upload_idfrom integer to string, clarifying that upload IDs are now public, random 18-character strings, not sequential integers. This applies to all relevant endpoint descriptions and path parameter documentation. [1] [2] [3] [4] [5] [6] [7] [8]tokensarray and atotalcount, and changed the defaultlimitfrom 100 to 10. [1] [2]Authentication and Error Handling:
max_uploadsfield to be optional (default 1) when creating a new token, and clarified error responses for upload completion. [1] [2]Workflow and Miscellaneous Documentation Updates:
.github/workflows/build-pr.ymland.github/workflows/main.ymlfor clarity. [1] [2]defaultfield in metadata schemas, TUS protocol features, and upload flow steps, including support for checksum verification and increased post-processing worker default. [1] [2] [3] [4] [5]