fix: only treat the documented episode range syntax as a range - #893
Merged
Merged
Conversation
Owner
|
Thanks could you explain why |
Follow up to arabcoders#886. Plex and jellyfin both document a range as sXXeYY-eZZ, so a bare number is only taken after a hyphen. S01E01.50, S01E01.2.0 and S01E01_02 are release tags now, not ranges. An E prefix is still honoured after any separator, so S01E01-E02, S01E01.S01E02 and E1001-E1002 keep working. Fixes names such as s05e07.10.chefs.compete.avi, where the episode title starts with a number. That parsed as episodes 7-10, which fits under the range limit, so the importer silently fabricated three episodes that do not exist.
Hoisting the tail shapes stopped one step short. Three things still restated what the tails had already decided.
Jellyfrog
force-pushed
the
fix/episode-range-year-tag
branch
from
September 20, 2026 20:17
9ba27e3 to
de1bfed
Compare
Contributor
Author
|
It’s because there are a lot of episodes named like show.s01e01.10.people.mkv, where the 10 belongs to the episode name. |
Owner
|
Thanks for the clarification, the only reason we need the parse_episode_range is due to lack of support from plex API afaik. jellyfin/emby provide indexRange directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #886
See individual commits, the second refactor commit isn't strictly needed and can be removed if you prefer.