Repository navigation
refactor: remove OIDC discovery cache and support HS256 - #896
Merged
Merged
Conversation
Follow up to #886. Plex and jellyfin both document a range as sXXeYY-eZZ, so a bare number is only taken after a hyphen. S01E01.50, S01E01.2.0 and S01E01_02 are release tags now, not ranges. An E prefix is still honoured after any separator, so S01E01-E02, S01E01.S01E02 and E1001-E1002 keep working. Fixes names such as s05e07.10.chefs.compete.avi, where the episode title starts with a number. That parsed as episodes 7-10, which fits under the range limit, so the importer silently fabricated three episodes that do not exist.
Hoisting the tail shapes stopped one step short. Three things still restated what the tails had already decided.
fix: only treat the documented episode range syntax as a range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and changes to configuration, OIDC authentication, and CI workflow. The most significant updates are the switch to integer-based log and backup retention settings, expanded OIDC algorithm support (including HS256 with stricter secret validation), and enhancements to the build pipeline for better artifact handling and Docker caching.
Configuration and Retention Policy Changes:
WS_LOGS_PRUNE_AFTERfrom a relative time string (e.g., "-7 DAYS") to an integer number of days (minimum 1), and introducedWS_BACKUP_PRUNE_AFTERfor backup retention (must be greater than 7 days). The corresponding config validation and usage logic were updated inconfig/config.php,config/env.spec.php, andsrc/Libs/Prune/FilePruner.php. [1] [2] [3] [4] [5]OIDC Authentication Improvements:
src/Libs/OidcService.php, with enforcement of a minimum 32-byte client secret for HS256. Documentation was updated to reflect supported algorithms and provide guidance for HS256 usage. [1] [2] [3] [4] [5]CI/CD Workflow Enhancements:
.github/workflows/build.ymlto add a container for the test job, include theredisPHP extension, improve Python setup and script execution, and handle frontend build artifact upload/download for both GitHub and Gitea. [1] [2] [3] [4] [5]container-${{ github.ref_name }}-${{ env.ARCH }}for both AMD64 and ARM64 builds. [1] [2]Other Technical Fixes:
sedreplacements during Docker build, ensuring correct version metadata injection. [1] [2] [3] [4]These changes improve reliability, clarity, and maintainability across configuration, authentication, and CI/CD processes.