Skip to content

fix: include admin homepage in route discovery - #4

Open
arch-err wants to merge 1 commit into
v2from
fix/homepage-admin-discovery
Open

fix: include admin homepage in route discovery#4
arch-err wants to merge 1 commit into
v2from
fix/homepage-admin-discovery

Conversation

@arch-err

Copy link
Copy Markdown
Owner

Summary

  • switch Homepage HTTPRoute discovery annotations from scalar gethomepage.dev/instance to named gethomepage.dev/instance.<name> entries
  • tag dashboard-visible routes for both their gateway instance and the admin instance
  • set the admin Homepage instanceName to admin
  • clean up stale comments around instance filtering

Verification

  • helm lint kubernetes/platform -f kubernetes/apps.yaml
  • helm template platform kubernetes/platform -f kubernetes/apps.yaml + YAML parse
  • helm lint kubernetes/platform -f kubernetes/infra.yaml
  • helm template platform kubernetes/platform -f kubernetes/infra.yaml + YAML parse
  • confirmed rendered manifests contain named instance annotations and zero scalar gethomepage.dev/instance annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant