feature/llm-lib-custom-env - #104
Open
DanielDango wants to merge 2 commits into
Open
DanielDango wants to merge 2 commits into
DanielDango wants to merge 2 commits into
Conversation
…ariables providers
…ation and Optimization classes
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds EnvironmentProvider plumbing across evaluation, optimization, preprocessing, and classifier construction, while retaining system-environment defaults.
Changes:
- Extends LLM-related constructors and factories with environment providers.
- Adds provider-aware
EvaluationandOptimizationconstructors. - Updates tests and architecture checks for
SystemEnvironment.
| File | Description |
|---|---|
| src/test/java/edu/kit/kastel/sdq/lissa/ratlr/e2e/Requirement2RequirementE2ETest.java | Updated as part of this pull request. |
| src/test/java/edu/kit/kastel/sdq/lissa/ratlr/e2e/MockPipelineE2ETest.java | Updated as part of this pull request. |
| src/test/java/edu/kit/kastel/sdq/lissa/ratlr/ArchitectureTest.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/promptoptimizer/ProTeGiOptimizer.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/promptoptimizer/PromptOptimizer.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/promptoptimizer/IterativeOptimizer.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/promptoptimizer/IterativeFeedbackOptimizer.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/preprocessor/SummarizePreprocessor.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/preprocessor/Preprocessor.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/Optimization.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/Main.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/Evaluation.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/configuration/EvaluationConfiguration.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/classifier/SimpleClassifier.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/classifier/ReasoningClassifier.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/classifier/PipelineClassifier.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/classifier/Classifier.java | Updated as part of this pull request. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/classifier/ChatLanguageModelProvider.java | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+116
to
+117
| promptOptimizer = PromptOptimizer.createOptimizer( | ||
| configuration.promptOptimizer(), goldStandard, metric, selector, this.environment); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for custom environment providers throughout the LiSSA pipeline.
Environment providers are handed down through signatures to provide secrets to the llm-lib constructors to access large language models.
Depends on ardoco/llm-access#14 and #95
Building up on this test cases may be refactored to use the MapEnvironment instead of overwriting the env files in SystemEnvironment.