Skip to content

Resolve conflicts in src/test/regress/sql/triggers.sql#2645

Merged
silent-observer merged 2 commits into
sync-14x-b13from
sync-14x-b13-michkov-24
Jun 8, 2026
Merged

Resolve conflicts in src/test/regress/sql/triggers.sql#2645
silent-observer merged 2 commits into
sync-14x-b13from
sync-14x-b13-michkov-24

Conversation

@silent-observer

Copy link
Copy Markdown

Commit ba9f18a added new test, however
commit 0f40a2d modified a line nearby.
Also modify the test for GPDB by adding a separate distribution key column.

Commit ba9f18a added new test, however
commit 0f40a2d modified a line nearby.
Also modify the test for GPDB by adding a separate distribution key column.
Comment thread src/test/regress/sql/triggers.sql Outdated
@silent-observer silent-observer changed the title Fix conflicts in src/test/regress/sql/triggers.sql Resolve conflicts in src/test/regress/sql/triggers.sql Jun 3, 2026
@RekGRpth

This comment was marked as resolved.

@RekGRpth

RekGRpth commented Jun 3, 2026

Copy link
Copy Markdown
Member

with ORCA

diff -I HINT: -I CONTEXT: -I GP_IGNORE: -U3 /home/gpadmin/gpdb_src/src/test/regress/expected/triggers.out /home/gpadmin/gpdb_src/src/test/regress/results/triggers.out
--- /home/gpadmin/gpdb_src/src/test/regress/expected/triggers.out	2026-06-03 16:44:32.047264114 +0000
+++ /home/gpadmin/gpdb_src/src/test/regress/results/triggers.out	2026-06-03 16:44:32.103263863 +0000
@@ -2570,8 +2570,12 @@
 insert into child3 values (42, 'CCC');
 -- update via parent sees parent-format tuples
 update parent set b = b + 1;
+DETAIL:  Failing row contains (CCC, 43).
+ERROR:  new row for relation "child1" violates partition constraint
 -- delete via parent sees parent-format tuples
 delete from parent;
+DETAIL:  Failing row contains (CCC, 42).
+ERROR:  new row for relation "child1" violates partition constraint
 -- insert into parent sees parent-format tuples
 insert into parent values ('AAA', 42);
 insert into parent values ('BBB', 42);
@@ -2603,6 +2607,8 @@
 drop trigger child3_delete_trig on child3;
 ERROR:  trigger "child3_delete_trig" for table "child3" does not exist
 delete from parent;
+DETAIL:  Failing row contains (CCC, 42).
+ERROR:  new row for relation "child1" violates partition constraint
 -- copy into parent sees tuples collected from children even if there
 -- is no transition-table trigger on the children
 copy parent (a, b) from stdin;

fixed by #2644

@silent-observer silent-observer merged commit 28ca034 into sync-14x-b13 Jun 8, 2026
1 check passed
@silent-observer silent-observer deleted the sync-14x-b13-michkov-24 branch June 8, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants