SMTChecker: Don't include boost::process in emscripten build - #17067
Merged
Merged
Conversation
In emscripten build, we don't have access to the filesystem or run external process. SMTSolver command should not be invoked in emscripten build; emscripten still uses bundled z3 to solve SMT queries.
blishko
force-pushed
the
no-boost-process-for-emscripten
branch
from
October 1, 2026 12:23
9cdbc39 to
ba722cb
Compare
blishko
marked this pull request as ready for review
October 1, 2026 15:10
clonker
approved these changes
Oct 1, 2026
clonker
left a comment
clonker
left a comment
Member
There was a problem hiding this comment.
it looks correct and good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In emscripten build, we don't have access to the filesystem or run external process.
SMTSolver command should not be invoked in emscripten build; emscripten still uses bundled z3 to solve SMT queries.