Conversation
GitLab keeps you on an MR's reviewer list after you approve, so the awaiting-review queue, its count and the bar dot kept every approved but unmerged MR. GitHub's review-requested:@me stops matching once you submit a review, so the GitLab tab was the odd one out. The query now filters on the viewer's own review state and keeps every state except APPROVED. A merge request approved by others but not by you still shows, and one whose approvals were reset by a new push comes back as UNAPPROVED. The count comes from the same field, so the tile and the dot follow without further changes. The tile's link gets the matching not[approved_by_usernames][] filter, so the dashboard it opens lists the same merge requests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitLab keeps you on an MR's reviewer list after you approve it. That means the GitLab Awaiting review queue, its count and the bar dot all keep counting every MR you've already approved that isn't merged yet. On GitHub,
review-requested:@mestops matching once you submit a review, so only GitLab behaves this way.Change
bin/gitwork:reviewRequestedMergeRequestsnow filters on your own review state. It keeps every state exceptAPPROVED(UNREVIEWED, REVIEWED, REVIEW_STARTED, REQUESTED_CHANGES, UNAPPROVED).UNAPPROVED.count, so they update without any other changes.Panel.qml: the Awaiting review tile now opens the dashboard with the matchingnot[approved_by_usernames][]filter, so the page lists the same MRs as the panel.Testing
./tests/run.sh: all suites pass. shellcheck wasn't run locally; the shell change is only inside the GraphQL heredoc.reviewStatesfilter andnot: {approvedBy: [viewer]}return the same result.Compatibility note
I've only tested this on gitlab.com. Older self-managed GitLab versions may not support the
reviewStatesargument, which would fail the whole query for that host. They may also lack the/dashboard/merge_requests/searchpage. If you want to support older instances, this could be put behind a version check or an opt-in setting.🤖 Generated with Claude Code