desktops: install libv4l-0 before rockchip-multimedia packages#887
desktops: install libv4l-0 before rockchip-multimedia packages#887igorpecovnik wants to merge 1 commit intomainfrom
Conversation
rockchip-multimedia-config's postinst expects the V4L2 userspace library to already be present. Mirror the ordering from armbian/build's extensions/mesa-vpu.sh by doing a separate pkg_install of libv4l-0 between pkg_update and the rockchip-multimedia-* batch, inside the existing noble/rk3588/vendor gate in _module_desktops_rockchip_multimedia.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 21 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/small
All remaining responsibilities of post_install_kernel_debs__3d moved to
armbian-configng's module_desktops, invoked via `module_desktops install
mode=build` during rootfs cache assembly:
- Mesa runtime + Vulkan drivers + glmark2/mesa-utils/vulkan-tools:
configng common.yaml mid tier (armbian/configng 3d8fff72).
- panthor-gpu DT overlay: _module_desktops_rockchip_multimedia
stage 2 (armbian/configng 41310eff).
- amazingfated ppa:liujianfeng1994/rockchip-multimedia + pin at
priority 1001 + rockchip-multimedia-config, libv4l-rkmpp,
gstreamer1.0-rockchip, libwidevinecdm0 install on noble/rk3588/
vendor: _module_desktops_rockchip_multimedia stage 1
(armbian/configng 1329d6b4, follow-up in armbian/configng#887
for the libv4l-0 pre-install ordering).
Caveat: configng sets up the PPA + pin and installs the multimedia
packages, but does not run a post-install `apt-get dist-upgrade
--allow-downgrades` to actively swap pre-installed chromium from
apt.armbian.com to the PPA's hardware-accelerated build. That swap
now happens on the user's first `apt upgrade` after boot (priority
1001 permits the downgrade-across-origins); shipped images carry
the apt.armbian.com chromium. If we want image-time swap back, a
follow-up in configng can add the dist-upgrade inside the same
noble/rk3588/vendor gate. The KDE-neon `apt-mark hold base-files`
and arm-noble/oracular `apt-mark hold libdav1d7` bracket calls are
dropped along with the dist-upgrade they were guarding.
No enable_extension or config references to mesa-vpu remain in the
build tree; no other callers to remove.
1 participant
Summary
rockchip-multimedia-config's postinst expectslibv4l-0to already be present — otherwise the configure step can fail on a fresh minimal image where the V4L2 userspace lib hasn't been pulled in yetpkg_install libv4l-0betweenpkg_updateand therockchip-multimedia-*batch, inside the existing noble/rk3588/vendor gate in_module_desktops_rockchip_multimediaextensions/mesa-vpu.sh(which does the sameapt-get install libv4l-0call before the multimedia batch)Follow-up to #885.
Test plan
module_desktops install de=<any> tier=mid mode=buildon an rk3588 / vendor / noble build reportslibv4l-0inACTUALLY_INSTALLEDbefore the rockchip-multimedia packagesmodule_desktops remove de=<name>purgeslibv4l-0via the manifest