Skip to content

Add custom 404 page for web routes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heronvalev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add custom 404 page for web routes #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1056dee
Add custom 404 page for web routes
heronvalev Apr 17, 2026
9765be5
Format with ruff
ivansantiagojr Apr 26, 2026
4da7f65
Change magic numbers for HTTPStatus enum
ivansantiagojr Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

import logfire
from fastapi import FastAPI, HTTPException, Request
from fastapi.responses import HTMLResponse, PlainTextResponse
from fastapi.responses import HTMLResponse, JSONResponse, PlainTextResponse
from fastapi.staticfiles import StaticFiles
from starlette.exceptions import HTTPException as StarletteHTTPException

from src.settings import settings
from src.templates_conf import templates
Expand All @@ -29,6 +30,27 @@ def read_root(request: Request):
return templates.TemplateResponse(request=request, name='index.html')


@app.exception_handler(StarletteHTTPException)
def custom_http_exception_handler(
request: Request, exc: StarletteHTTPException
):
if exc.status_code == HTTPStatus.NOT_FOUND:
if request.url.path.startswith('/api'):
return JSONResponse(
status_code=HTTPStatus.NOT_FOUND,
content={'detail': 'Not Found'},
)

return templates.TemplateResponse(
request=request,
name='404.html',
context={'path': request.url.path},
status_code=404,
)

raise exc


@app.get('/api/list', response_class=PlainTextResponse)
def list_templates():
"""
Expand Down
45 changes: 45 additions & 0 deletions src/templates/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="description" content="Page not found.">
<link rel="shortcut icon" href="/static/favicon.ico" />
<link rel="manifest" href="/static/site.webmanifest" />
<meta name="apple-mobile-web-app-title" content="DontCommit" />
<link rel="icon" type="image/svg+xml" href="/static/favicon.svg" />
<link rel="icon" type="image/png" href="/static/favicon-96x96.png" sizes="96x96" />
<link rel="apple-touch-icon" sizes="180x180" href="/static/apple-touch-icon.png" />

<title>404 | Do Not Commit by Artefatto</title>

<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Instrument+Serif:ital@0;1&display=swap" rel="stylesheet">
<link rel="stylesheet" href="/static/css/index.css">
</head>
<body>
<header>
<h1><a href="https://github.com/artefatto">Artefatto</a></h1>
<nav>
<ul>
<li><a href="https://github.com/artefatto/donotcommit">Source</a></li>
<li><a href="/docs">Docs</a></li>
<li><a class="highlight" href="https://github.com/sponsors/artefatto">Support</a></li>
</ul>
</nav>
</header>

<main>
<section>
<h1>404 <br><em>Not Found</em></h1>
<p>The page <code>{{ path }}</code> does not exist.</p>
<p><a class="highlight" href="/">Go back home</a></p>
</section>
</main>

<footer>
<small>A clean repo initiative by <a href="https://ivansantiago.net">Ivan Santiago</a> and <a href="https://thigcampos.com">Thiago Campos</a>.</small>
</footer>
</body>
</html>
Loading