Fix type annotations and bump mypy python_version for mypy 2.0#494
Closed
quiqueporta wants to merge 1 commit intoarthurdejong:masterfrom
Closed
Fix type annotations and bump mypy python_version for mypy 2.0#494quiqueporta wants to merge 1 commit intoarthurdejong:masterfrom
quiqueporta wants to merge 1 commit intoarthurdejong:masterfrom
Conversation
mypy 2.0 dropped support for python_version 3.9 in [mypy] config and flagged two empty-dict definitions as missing annotations, which broke the tox -e mypy CI job for any new commit. * Bump python_version in setup.cfg from 3.9 to 3.10. * Annotate _soap_clients in stdnum/util.py. * Annotate _country_modules in stdnum/eu/vat.py, which also resolves the no-any-return warning in _get_cc_module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy 2.0 dropped support for
python_version = 3.9in the[mypy]config and flagged two empty-dict definitions as missing annotations, which currently breaks thetox -e mypyCI job on any new commit.python_versioninsetup.cfgfrom 3.9 to 3.10._soap_clientsinstdnum/util.py._country_modulesinstdnum/eu/vat.py, which also resolves theno-any-returnwarning in_get_cc_module.