Skip to content

feat(frontend): add native image viewer - #166

Draft
sandersonstabo wants to merge 1 commit into
agent/ui-input-port-3422556from
agent/frontend-image-viewer-port-531eeab
Draft

feat(frontend): add native image viewer#166
sandersonstabo wants to merge 1 commit into
agent/ui-input-port-3422556from
agent/frontend-image-viewer-port-531eeab

Conversation

@sandersonstabo

@sandersonstabo sandersonstabo commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Adds a native GPUI image viewer with controlled lifecycle state, theme-aware modal presentation, deterministic geometry, dismissal semantics, and focused behavior/Clippy coverage.

Stacked on #165.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Adds a native gpui full-screen image viewer with pure controlled state, theme-aware styling, and deterministic fitting geometry. The viewer never decodes images and never manages inspection resources directly; it only queues retain/release actions for the caller to drain and execute.

Design notes

  • Open/close state, geometry, and style are pure types tested without a GPUU window.
  • gpui 0.2.2 lacks backdrop filters, z-index, and an OS accessibility tree, so those are kept as typed intents and sibling paint order.
  • Backdrop click, close button, and Escape all close through the same controlled transition and restore the previous focus.

Written for commit 5ca2c1c. Summary will update on new commits.

Review in cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant