feat(frontend): add native image viewer - #166
Draft
sandersonstabo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native GPUI image viewer with controlled lifecycle state, theme-aware modal presentation, deterministic geometry, dismissal semantics, and focused behavior/Clippy coverage.
Stacked on #165.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a native
gpuifull-screen image viewer with pure controlled state, theme-aware styling, and deterministic fitting geometry. The viewer never decodes images and never manages inspection resources directly; it only queues retain/release actions for the caller to drain and execute.Design notes
gpui0.2.2 lacks backdrop filters, z-index, and an OS accessibility tree, so those are kept as typed intents and sibling paint order.Written for commit 5ca2c1c. Summary will update on new commits.