Skip to content

Added showAllCommandsWhenNoneMatches boolean option - #1122

Open
dbuezas wants to merge 1 commit into
asabaylus:mainfrom
dbuezas:feat/showAllCommandsWhenNoneMatches-option
Open

Added showAllCommandsWhenNoneMatches boolean option #1122
dbuezas wants to merge 1 commit into
asabaylus:mainfrom
dbuezas:feat/showAllCommandsWhenNoneMatches-option

Conversation

@dbuezas

@dbuezas dbuezas commented Mar 12, 2022

Copy link
Copy Markdown

Not a breaking change.
Using this option, the command palette can be configured to be more like that of vscode (i.e show no commands when nothing matches)

…n be configured to be more like that of vscode
@dbuezas

dbuezas commented Mar 12, 2022

Copy link
Copy Markdown
Author

It also fixes a bug of fuzzy search not applied when the commands array changes but the query value doesn't

@asabaylus asabaylus self-assigned this Mar 20, 2022
@dbuezas

dbuezas commented Mar 24, 2022

Copy link
Copy Markdown
Author

Any action required on my side?
Thanks

@asabaylus

Copy link
Copy Markdown
Owner

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants