Skip to content

Fix sonar linter #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ensary wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix sonar linter #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d83460
https://sonarcloud.io/project/issues?issueStatuses=OPEN&id=asecurityt…
ensary May 15, 2026
b5a0178
https://sonarcloud.io/project/issues?issueStatuses=OPEN&id=asecurityt…
ensary May 15, 2026
1dc5dd5
remove drive-by change to net/http
ensary May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion healthcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type HealthCheckHandler struct {
}

// Handle responds with a 200 by default
func (h *HealthCheckHandler) Handle(w http.ResponseWriter, r *http.Request) {
func (h *HealthCheckHandler) Handle(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("Success"))
}
6 changes: 3 additions & 3 deletions router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ type RouterConfig struct {
// This version returns a mux from the chi project
// as a convenience for cases where custom middleware or additional
// routes need to be configured.
func NewDefaultRouter(conf *RouterConfig) *chi.Mux {
router := chi.NewMux()
func NewDefaultRouter(_ *RouterConfig) *http.ServeMux {
router := http.NewServeMux()
healthCheckHandler := &HealthCheckHandler{}

router.Get("/healthcheck", healthCheckHandler.Handle)
router.HandleFunc("/healthcheck", healthCheckHandler.Handle)

return router
}
Loading