Skip to content

chore: update dependencies, address warnings, and fix failing tests - #134

Merged
zachdaniel merged 3 commits into
ash-project:mainfrom
omgitzjoe:update-dependencies-current
Oct 8, 2026
Merged

zachdaniel merged 3 commits into
ash-project:mainfrom
omgitzjoe:update-dependencies-current

Conversation

@omgitzjoe

Copy link
Copy Markdown
Contributor

Summary

  • Updated dependencies to match current Ash specifications, enabled and fixed failing and excluded tests.

Root cause

  • Runtime sorting returned a bare list instead of {:ok, records}.
  • Ash requires an explicit setting for counting string lengths, and Spark expects metadata fields on DSL entity structs.
  • The Hackernews test sent Firebase’s limitToFirst parameter without the required orderBy parameter.

Changes

  • Updated Ash, Spark, Req, Sobelow, ExAST, and Makeup in mix.lock.
  • Removed unused libgraph lockfile entry.
  • Preserved the success tuple when sorting query results.
  • Configured Ash to count string lengths using codepoints.
  • Added __spark_metadata__ to the Field and Endpoint structs.
  • Replaced Domain.read!() call with Ash.read!().
  • Added Firebase ordering to Hackernews test and enabled it in normal test runs.
  • Suppressed Tesla builder deprecation warnings pending the Req migration.
  • Warning about rate limits remains

How I tested it

  • mix test: 4 tests, 0 failures, including the excluded Hackernews test. Previously 4 tests, 1 failed, 1 was excluded.
  • mix check: all enabled checks passed.
  • git diff --check: passed.

Notes for reviewers

  • This is preparation for changing to Req from Tesla. Tesla is still the HTTP client.
  • Dependencies and tests are simply updated so that the next task (issue Replace Tesla with Req #107) has a clean slate.
  • Happy to make changes if I missed the target.

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel

Copy link
Copy Markdown
Collaborator

Very cool. Would be cool to see this project revived TBH

@zachdaniel
zachdaniel merged commit 333bffc into ash-project:main Oct 8, 2026
26 checks passed
@zachdaniel

Copy link
Copy Markdown
Collaborator

🚀 Thank you for your contribution! 🚀

@omgitzjoe
omgitzjoe deleted the update-dependencies-current branch October 8, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants