Repository navigation
fix: don't infer renames or skip dev migration check in codegen --check - #881
Merged
zachdaniel merged 1 commit intoOct 5, 2026
Merged
Conversation
In --check mode, yes?/2 answered true to rename prompts while prompt/2 returned a placeholder, so multiple removed + added attributes raised "Could not get matching name after 3 attempts." before the remaining _dev migration check could run. - check for remaining _dev migrations before rename inference - never confirm interactive questions in --check mode Fixes ash-project#841
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #841
Implements the fix agreed in #841:
--checkreports remaining_devmigrations before snapshot merging / rename inference, instead of only after operations are computed.yes?/2returnsfalsein--checkmode, so check never confirms an interactive rename (attribute, table, or schema move). Ambiguous changes surface as add/remove and raisePendingCodegen.Regression tests in
test/migration_generator_test.exs(--check option):--devmigration remaining → exits with the dev-migration message (previouslyCould not get matching name after 3 attempts.).PendingCodegen, no rename in the diff (previously the same crash).Behavior change:
--checknow fails whenever_devmigrations remain, even if the diff against the last production snapshot is empty.Contributor checklist
Leave anything that you believe does not apply unchecked.