Repository navigation
Support optional bearer authentication in benchmark clients - #890
Merged
Merged
Conversation
ashhart
added a commit
that referenced
this pull request
Oct 16, 2026
…rry one reuse_served read the reply's 12-character token_sha, and two missing digests compared equal. It now reads token_sha256, keeps it only when it is 64 hex digits, and fails a reply when either arm has none. A resumed reply that is no sooner than the fresh one is listed on its own timing line instead of failing the equality check. #890's auth fixtures answer with a full token_sha256 beside their short fingerprint, as the server does, so the clients' #862/#863 digest checks see a valid reply.
ashhart
added a commit
that referenced
this pull request
Oct 16, 2026
…VIEW names the refused GLM pair requests rightly One line each for #881, #882, #883, #889, #890, #709, #848, #892, #867, #868, #871 and #873, crediting their authors. ZIG-PREVIEW said a two-Mac GLM pair refuses "temperature-1" requests; it refuses any temperature above 0 (backend.zig and engine.zig both test temperature > 0).
Owner
|
Thank you, @alenperic, for adding bearer authentication and output redaction to the benchmark clients. #890 is included in 1.0.12 as merge b9289d6, at 0d3ad79. The clients read the key from the variable named by --api-key-env, send it to the requested endpoint and refuse to forward it on redirects. They redact the configured key from client output. The merge retains #862/#863's full digests. Our a83a85d adds matching token_sha256 values to the authentication fixtures. The client tests pass under Python 3.12 on macOS and Linux. The concurrency checks used the updated clients and compared complete replies by full digest. Posted by Ash's AI Assistant Synthena |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds optional bearer authentication to
tools/bench_openai.pyandtools/bench_concurrent.pythrough--api-key-env NAME, allowing benchmarks against authenticated OpenAI-compatible endpoints. Authentication is enabled only when the option is supplied, and the credential is read from the selected environment variable.Receipt
0d3ad792fd4bc0774bfa714eadf0d943bdb0f209, based onc7137bb31a7dad924fb541a7068422127b9a94b2.python -m unittest discover -s tools/tests -v— 26 passed, 0 failed, 0 errors, 0 skipped, on both tested environments. The authentication regression cases fail against the parent implementation.git diff --checkandgit diff --cached --checkpassed.Checklist