Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f56a589df1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| repo_root="$(git rev-parse --show-toplevel)" |
There was a problem hiding this comment.
Configure repo so the committed pre-push hook is used
This hook is added under .githooks/pre-push, but Git executes hooks from $GIT_DIR/hooks unless core.hooksPath is configured to point elsewhere; in this commit I only found the hook file itself and no repo bootstrap/config/docs that set core.hooksPath, so most contributors will never run these checks and can push without the intended composer analyze/composer test gate.
Useful? React with 👍 / 👎.
This pull request introduces several improvements to repository workflow, documentation, and automation. It adds standardized commit and pull request guidelines, a new GitHub Actions workflow for PHP CI, a pre-push Git hook for local checks, and updates project metadata and badges. Additionally, it updates dependencies to the latest versions and defines a Composer test script.
Repository workflow and automation:
php.yml) to automatically run tests on PHP 8.4 and latest versions for pushes and pull requests..githooks/pre-push) that runscomposer analyzeandcomposer testif defined, ensuring local code quality before pushing.testscript for consistent test execution.Documentation and contribution guidelines:
docs/commit-and-pr-guidelines.mdand.github/copilot-instructions.md, and a new pull request template to standardize contributions. [1] [2] [3]README.mdwith new badges, contribution workflow references, improved quick start and advanced usage examples, and clarified features.Project metadata and dependencies:
meta/repo-health.jsonto document repository health and status.composer.jsonto require the latest compatible versions ofassegaiphp/validation,assegaiphp/collections, andassegaiphp/util.