Skip to content

Change from degrees to radians #45

Description

@cdeil

Currently internally in the code we use angles in degrees in most places and also use this to store inputs and outputs in tables.

I think we should use radians, because that's what all coordinate packages use internally for the calculations, so if we start doing any speed benchmarking, that should be the input / output format of the data we pass in and out. Also changing to radians will get rid of a few lines of conversion code.

@astrofrog - Would you be OK with this change? I could do it now.

In any case, as mentioned by @astrofrog at #42 (comment) , we should store the angle units used in the input / output tables, e.g. by using ECSV once it's merged into Astropy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions