Conversation
- Added tests for the method.
- Added the tests for these methods.
…s constructed by combining a tilt solution and 1D wavelength solution. - Revised the changelog and docs.
…by the pixel wavelength width, which made the output off by the local dispersion and broke flux conservation. The output is now a bin-averaged flux density with the bin edges stored on the spectral axis. - Changed WavelengthSolution2D.resample to support decreasing dispersion, copy the input metadata, return no uncertainty when the input has none, and reject nbins=0.
hpparvi
requested review from
cshanahan1,
kbwestfall,
kecnry and
tepickering
September 29, 2026 09:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 92.52% 93.15% +0.63%
==========================================
Files 18 19 +1
Lines 2341 2558 +217
==========================================
+ Hits 2166 2383 +217
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
WavelengthSolution2Dclass for 2D wavelength calibrationWavelengthSolution1D.from_gwcsmethod to create a 1D wavelength solution from an exported one, andTiltSolution.to_asdfandTiltSolution.from_asdfmethods to serialise 2D tilt solutions.The 2D wavelength solution is created by chaining a 2D tilt solution and a 1D wavelength solution, and provides method to map between the pixel and wavelength space (both directions), to serialise the mapping to ASDF, and to resample 2D frames losslessly.
AI/LLM Disclaimer: The same as in #319. I've used Claude Code with Fable 5.1 to co-develop the PR, but I understand what the code does and how it works, and can explain it when needed.