Skip to content

fix: support slash-based branches and multi-dot filenames in URL parsing #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwl2005 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: support slash-based branches and multi-dot filenames in URL parsing #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ff09c
Fix regex pattern for GitHub web URLs
lwl2005 May 2, 2026
100e99c
Fix extension extraction to handle missing extensions
lwl2005 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/domains/models/SpecificationFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export async function fileExists(name: string): Promise<boolean> {
return true;
}

const extension = name.split('.')[1];
const extension = name.includes('.') ? name.split('.').pop() : '';

const allowedExtenstion = ['yml', 'yaml', 'json'];

Expand Down
2 changes: 1 addition & 1 deletion src/domains/services/validation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const convertGitHubWebUrl = (url: string): string => {

// Handle GitHub web URLs like: https://github.com/owner/repo/blob/branch/path
// eslint-disable-next-line no-useless-escape
const githubWebPattern = /^https:\/\/github\.com\/([^\/]+)\/([^\/]+)\/blob\/([^\/]+)\/(.+)$/;
const githubWebPattern = /^https:\/\/github\.com\/([^\/]+)\/([^\/]+)\/blob\/(.+)\/(.+)$/;
const match = urlWithoutFragment.match(githubWebPattern);

if (match) {
Expand Down
Loading