fix(completion): improve semantic context for Solidity expressions#226
Draft
rifuki wants to merge 1 commit into
Draft
fix(completion): improve semantic context for Solidity expressions#226rifuki wants to merge 1 commit into
rifuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #225.
Summary
This improves completion behavior in several semantic contexts that are common in Solidity projects:
RafluxTypes.ListingStatus.AC....typeDescriptionson enum/struct declarations, allowingRafluxTypes.ListingStatus.to complete enum values.using Library for Type;extension methods to values of the matching type, includingusing SafeERC20 for IERC20;sopaymentToken.can completesafeTransfer/safeTransferFrom.IERC20..Why
Without these fixes, valid Solidity can look unsupported in the editor. One especially confusing case is
SafeERC20:IERC20itself does not definesafeTransferFrom, butusing SafeERC20 for IERC20;makes it callable onIERC20values. The LSP should reflect that compiler behavior in completion.Tests
Also smoke-tested through Neovim headless against a real Foundry project:
paymentToken.includessafeTransferandsafeTransferFrom.emit TicketBought(list...)includes local/function-scope variables as LSPVariableitems.RafluxTypes.ListingStatus.returns enum members.