Skip to content

fix(TermCache): log+skip anchorless orphan terms instead of throwing #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sriram-atlan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(TermCache): log+skip anchorless orphan terms instead of throwing #2523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/cache/TermCache.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ class TermCache(
/** {@inheritDoc} */
override fun lookupById(id: String?) {
val result = lookupById(id, 0, ctx.client.maxNetworkRetries)
if (result != null) cache(result.guid, getIdentityForAsset(result), result)
if (result != null) {
val identity = identityForAssetOrLog(result) ?: return
cache(result.guid, identity, result)
}
}

/** {@inheritDoc} */
Expand Down Expand Up @@ -108,6 +111,28 @@ class TermCache(
"${asset.name}${GlossaryXformer.GLOSSARY_DELIMITER}$glossaryName"
} ?: throw IllegalStateException("Term found with no anchor: ${asset.toJson(client)})")

/**
* Safe variant of [getIdentityForAsset] for tenant-wide scans. Catches the "term has no
* anchor" inconsistency that can result from soft-deleted anchor edges left behind by
* test residue or partially-failed move operations, logs it, and returns null so the
* caller can skip caching this one term rather than aborting the entire refresh.
*
* Without this guard a single orphan term causes [refreshCache] to throw, which in turn
* fails downstream asset-import tests that depend on the term cache being initialised —
* unrelated tests blow up because of unrelated data anomalies elsewhere in the tenant.
*/
private fun identityForAssetOrLog(asset: GlossaryTerm): String? =
try {
getIdentityForAsset(asset)
} catch (e: IllegalStateException) {
logger.warn {
"Skipping term ${asset.guid} (name='${asset.name}') with no resolvable anchor — likely an orphan " +
"from a soft-deleted anchor edge. The term is still ACTIVE but its anchor relationship has " +
"no ACTIVE edge to a glossary. Cache will continue without this entry."
}
null
}

/** {@inheritDoc} */
override fun refreshCache() {
val count = GlossaryTerm.select(client).count()
Expand All @@ -119,7 +144,8 @@ class TermCache(
.stream(true)
.forEach { term ->
term as GlossaryTerm
cache(term.guid, getIdentityForAsset(term), term)
val identity = identityForAssetOrLog(term) ?: return@forEach
cache(term.guid, identity, term)
}
}
}
Loading