CI: fix esp32c61 flappiness#2298
Conversation
In testing harness esp32c61 struggles with all the wifi tests. Signed-off-by: Peter M <petermm@gmail.com>
| "Network: ", | ||
| SSID, | ||
| ", BSSID: ", | ||
| bssid_hex(BSSID), |
There was a problem hiding this comment.
This is a test. Are we asserting against the BSSID hex?
There was a problem hiding this comment.
No asserts, suppose this an indirect test, and the entire thing is also indirectly an example.
Do you want to get rid of bssid_hex helpers? and just remove BSSID logging?
There was a problem hiding this comment.
I the values are know in advance we should at least match them against some know values, so we can detect bugs in the network driver.
Anyway this suggestion is not about C61 flappiness, so it can be discuted/postponed to another PR.
There was a problem hiding this comment.
OK. I was just suggesting we are modifying dead code. No one reads this log I guess. But we can keep this homemade bin to hex.
There was a problem hiding this comment.
I don’t think the BSSID of the mock access point can be reliably be known ahead of time. I only added the logging to make the test more useful if someone wanted to smoke test on local hardware. For the sake of the CI it probably makes more sense to remove all logging rather that add unnecessary code that will make the CI take longer to run.
4 participants
In testing harness esp32c61 struggles with all the wifi tests, so we limit and optimise a bit.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later