feat: put the live demo in the hero, replacing the mockup - #53
Merged
Conversation
added 2 commits
August 18, 2026 17:19
The demo was below the features grid, well past the fold, while the hero showed an SVG drawing of exactly the composition the demo actually runs. Swapping it into the home-hero-image slot puts the real thing in the first screen and deletes the drawing that could drift from it. Rendered through a theme slot rather than ClientOnly, so the iframe is in the served HTML instead of appearing only after hydration. The demo's own layout tightens to fit the narrower hero column.
The demo is built into docs-site/public, but the paths filter only watched docs-site/**, so a demo-only change would have left the homepage showing the previous build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The demo shipped below the features grid, well past the fold — while the hero showed an SVG drawing of exactly the composition the demo actually runs. This swaps the real thing into the
home-hero-imageslot and deletes the drawing, which could only ever drift from the product.Rendered through a theme slot rather than
<ClientOnly>, so the iframe is present in the served HTML instead of appearing only after hydration. The demo's own layout tightens (340px panel column, 430px body, smaller type) to read well in the narrower hero column, and stacks vertically under 720px.Also fixes a latent CI gap:
deploy-docsonly watcheddocs-site/**, but the demo is built intodocs-site/public. A demo-only change would have left the homepage serving the previous build. The paths filter now coverspackages/extension/demo/**and the demo Vite config.No version bump: the site deploys from
main, and neither the extension nor the MCP server changed behaviour.Test plan
pnpm typecheckclean;pnpm test1171 passing;pnpm buildcleanbuild:demosucceeds and the site build embeds the iframe server-side —dist/index.htmlcontainshome-demo-frameanddemo/index.htmlsidepanel-hero-landscapeno longer referenced)