fix: remove Auth0Server dependency from getClaims and requireClaims - #10
Open
yogeshchoudhary147 wants to merge 1 commit into
Open
fix: remove Auth0Server dependency from getClaims and requireClaims#10yogeshchoudhary147 wants to merge 1 commit into
yogeshchoudhary147 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getClaimsandrequireClaimsno longer require a fullAuth0ServerconfigverifyJwtnow readsAUTH0_DOMAINandAUTH0_AUDIENCEdirectly from env vars instead of callinggetInstance(), which triggered the full session config validationBefore this fix, a developer using only
requireClaimswas forced to setAUTH0_CLIENT_ID,AUTH0_CLIENT_SECRET,AUTH0_SESSION_SECRET, andAUTH0_APP_BASE_URL— none of which are used during JWT verification.Test plan
requireClaims/getClaimswork with onlyAUTH0_DOMAIN+AUTH0_AUDIENCEsetConfigurationErrorthrown whenAUTH0_DOMAINis missingConfigurationErrorthrown whenAUTH0_AUDIENCEis missingnpx vitest run— all 320 tests pass