feat(react): add keyboard-accessible row click to DataTable - #491
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rax7389
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the row-click behaviour from the UDS data table into our shared
DataTable, so rows are reachable by keyboard and not just by pointer.Why
DataTablealready supportedonRowClick, but only as a bareonClickon<tr>: notabIndex, norole, no key handling. That is invisible to keyboard and screen-reader users.It matters now because of permission gating. Once a row's action menu is hidden for users without mutating permissions, row-click becomes their only route to a details view. Without keyboard support, those users cannot reach member, invitation, domain or provider details at all.
What
tabIndex={0}and an accessible label whenonRowClickis setfocus-visiblering so keyboard focus is visibleThe guard uses UDS's focusable-element check rather than relying on every cell remembering to stop propagation:
Packages
packages/core— adds theview_rowlabel toen-US,frandjapackages/react—DataTableexamplesTesting
Tested after integrating with Member Table:

react typecheck clean, 1840 tests / 112 files pass
core typecheck clean, 1109 tests pass
eslint and prettier clean
This change adds unit test coverage
Tested for both SPA and RWA flows, all example apps working
All existing and new tests complete without errors
Checklist
Contributing