tirex-2: cache checkpoint from S3 in wrapper - #175
Merged
Conversation
Wrap model_path with fev.utils.maybe_cache_from_s3 so the tirex-2 wrapper accepts an s3:// prefix (matching the chronos/toto wrappers), downloading the checkpoint locally before load_model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tirex-2wrapper passedmodel_pathstraight intoload_model, so ans3://prefix would not resolve (unlike thechronos/chronos-2/toto-2.0wrappers, which cache from S3 first).Wrap it with
fev.utils.maybe_cache_from_s3so the checkpoint is downloaded locally before loading. Local (s3://and hub) paths are unaffected.Sanity-checked locally:
evaluate.py -m tirex-2 -k '{"model_path":"s3://.../TiRex-2/","device":"cpu"}'on one task now downloads the checkpoint and produces metrics (exit 0).