fix(examples): stop claiming a guessed selector is a flagged TODO - #493
Open
HappyDevs1 wants to merge 1 commit into
Open
fix(examples): stop claiming a guessed selector is a flagged TODO#493HappyDevs1 wants to merge 1 commit into
HappyDevs1 wants to merge 1 commit into
Conversation
purchase-info-records-report.flow.yaml's header said two steps were left as flagged TODOs rather than guessed, but only one was — the tile-navigation step carried a resolved selector with its own comment admitting it was "a best-effort guess... not a confirmed label," directly contradicting the header. The step is now an honest, unresolved TODO matching its sibling's shape, and a permanent test parses the whole file so this can't silently regress. Fixes #490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/fiori/purchase-info-records-report.flow.yaml's header claimed "two steps left as flagged TODOs rather than guessed," but only one actually was — the tile-navigation step resolved to a concrete selector (Click "Display Purchasing Info Record") with its own comment admitting it was "a best-effort guess... not a confirmed label," directly contradicting the header.Observed - "...").purchase_info_records_example_parses_as_a_multi_surface_flow, so this file's parseability is now covered byexamples_resolve.rsgoing forward.A bug found and fixed during verification
The first version of the replacement step used a colon (
options: "Manage Info Records") inside an unquoted YAML plain scalar — read by YAML as a nested mapping key, breaking the parse. Fixed by using an em dash instead, matching the sibling step's punctuation (dash before quoted text, never colon-space).Test plan
cargo test -p flowproof-cli --test examples_resolve— 7/7 passcargo fmt --checkcargo clippy -p flowproof-cli --all-targets -- -D warningsFixes #490
🤖 Generated with Claude Code