spec-submit: gate AC on whether this change can break it, dedupe rules#27
Open
tulioz wants to merge 1 commit into
Open
spec-submit: gate AC on whether this change can break it, dedupe rules#27tulioz wants to merge 1 commit into
tulioz wants to merge 1 commit into
Conversation
brain-crystal
left a comment
brain-crystal
left a comment
Contributor
There was a problem hiding this comment.
Don't forget to update version
| 1. **This change can break it.** Trace the AC to the diff. If nothing in this change could flip it from pass to fail — it names a code path the diff doesn't touch, it guards behavior outside this change's scope — it is out of scope. Drop it, however important the behavior is in the abstract. | ||
| 2. **A violation has a named victim.** Ask "if this were violated, what gets worse, and for whom?" A specific impact on a specific party — a user hits a bug, the next maintainer trips on an inconsistent pattern, the prod operator can't debug a silent failure — means keep it. A vague answer ("things would just be less good", "code wouldn't be as clean") means filler, delete it. | ||
|
|
||
| If the honest answer is vague ("things would just be less good", "code wouldn't be as clean"), the AC is filler, delete it. |
Contributor
There was a problem hiding this comment.
Do. we need to remove this line ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the north-star only checked whether a violation would be bad, not whether this change could cause it, so it greenlit AC for code the diff never touches. adds a causality gate, scopes preserve-behavior to touched code, and dedupes the AC rules.