chore(IAWPRegistry): remove unused WorknetTokenFactoryUpdated event#9
Open
fadai216 wants to merge 1 commit into
Open
chore(IAWPRegistry): remove unused WorknetTokenFactoryUpdated event#9fadai216 wants to merge 1 commit into
fadai216 wants to merge 1 commit into
Conversation
6a210d4 to
3dcae25
Compare
The event is declared on the IAWPRegistry interface but never emitted anywhere in the codebase. worknetTokenFactory is an immutable set in the AWPRegistry constructor; there is no setWorknetTokenFactory function. Removing the dead event prevents downstream indexers and skills from subscribing to something that can never fire.
3dcae25 to
1095009
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IAWPRegistry.soldeclares an event that is never emitted anywhere in the codebase:The
worknetTokenFactoryis an immutable passed toAWPRegistryin its constructor — there is nosetWorknetTokenFactorysetter andgrepconfirms zeroemitsites. The event is therefore dead interface surface.Why it matters
Downstream indexers and skills subscribe to interface events. The
awp-core/awp-skillprotocolpreset currently listsWorknetTokenFactoryUpdatedamong its tracked events (see that repo's README), so skill users wire up a subscription that can never fire. Misleading for integrators.Fix
Remove the event declaration from the interface. Zero behavior change (nothing ever emitted it).
A separate follow-up PR against
awp-core/awp-skillshould drop it from theprotocolpreset and adjust the count. Done separately to keep this PR minimal.Diff
interface IAWPRegistry { ... event WorknetPaused(uint256 indexed worknetId); event WorknetResumed(uint256 indexed worknetId); event WorknetCancelled(uint256 indexed worknetId); event WorknetRejected(uint256 indexed worknetId); event WorknetBanned(uint256 indexed worknetId); event WorknetUnbanned(uint256 indexed worknetId); // ── Governance parameter events ── event GuardianUpdated(address indexed newGuardian); event InitialAlphaPriceUpdated(uint256 newPrice); event InitialAlphaMintUpdated(uint256 amount); - event WorknetTokenFactoryUpdated(address indexed newFactory); event DefaultWorknetManagerImplUpdated(address indexed newImpl); ... }