Repository navigation
Open
Conversation
satyakigh
added this pull request to stack #701
October 7, 2026 20:03
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/vitestThe overall line coverage in commit 1a9dde0 in the Show a line coverage summary of the most impacted files.
Updated |
satyakigh
dismissed
mrinaudo-aws’s stale review
October 9, 2026 21:44
The merge-base changed after approval.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Database (FileDB and LMDB)
Each store keeps its data in a versioned directory (
filedb/v4,lmdb/v7) and deletes older versions two minutes after startup. When 1.12.0 moved FileDB from v3 to v4, it deletedfiledb/v3while older language server processes on the same machine (other IDE windows, other IDEs) were still using it, so those processes failed on every read. That is thefiles.scan.errorspike. Each store now writes a.heartbeatfile in its own directory at startup and every 60 seconds, and cleanup skips any older directory that was used in the last 24 hours. Skipped directories are counted asoldVersion.cleanup.skipped.cfn-validate
Every
validate.errorin production is thecloudformation-validateengine running out of memory on templates with many conditional (Fn::If) properties. The engine ran on the main thread, so a large template froze the language server for seconds, and once it ran out of memory every later validation failed too. The engine now runs in a worker thread with the same 128 MB heap limit as cfn-lint, and each validation has a 30 second timeout. If the worker crashes, exits, or times out, it is terminated, its memory is released, and validation is turned off for the rest of the session with a singlevalidate.error. The main thread is never blocked, and one template is validated at a time.Worker and retry failures now use typed error classes (
WorkerExitError,WorkerFailureError,RetryError) instead of plainError; messages are unchanged.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.