Skip to content

Fix E1018 false positive on Fn::Split over Fn::GetStackOutput #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satyakigh merged 2 commits into from
Sep 30, 2026
Merged

Fix E1018 false positive on Fn::Split over Fn::GetStackOutput #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfa415
Fix E1018 false positive on Fn::Split over Fn::GetStackOutput
satyakigh Sep 30, 2026
3b101a4
remove comments
satyakigh Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 79 additions & 39 deletions src/resources/expected/validation_reports6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,85 @@
}
]
},
"good/functions/split_get_stack_output.yaml": {
"filePath": "good/functions/split_get_stack_output.yaml",
"status": "OK",
"metadata": {
"resourcesScanned": 3,
"counts": {
"fatal": 0,
"errors": 0,
"warnings": 0,
"informational": 3,
"debug": 0
},
"suppressed": 0,
"strict": false,
"severityLevel": "DEBUG"
},
"diagnostics": [
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'Bucket' of type 'AWS::S3::Bucket' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "Bucket",
"entityType": "Resource",
"resourceType": "AWS::S3::Bucket"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 6,
"startColumn": 5,
"endLine": 6,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
},
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'AllHeaders' of type 'AWS::SSM::Parameter' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "AllHeaders",
"entityType": "Resource",
"resourceType": "AWS::SSM::Parameter"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 21,
"startColumn": 5,
"endLine": 21,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
},
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'FirstHeader' of type 'AWS::SSM::Parameter' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "FirstHeader",
"entityType": "Resource",
"resourceType": "AWS::SSM::Parameter"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 34,
"startColumn": 5,
"endLine": 34,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
}
]
},
"good/functions/sub.yaml": {
"filePath": "good/functions/sub.yaml",
"status": "OK",
Expand Down Expand Up @@ -16333,44 +16412,5 @@
"phase": "LINT"
}
]
},
"good/sam/function_dlq_valid.yaml": {
"filePath": "good/sam/function_dlq_valid.yaml",
"status": "OK",
"metadata": {
"resourcesScanned": 1,
"counts": {
"fatal": 0,
"errors": 0,
"warnings": 0,
"informational": 1,
"debug": 0
},
"suppressed": 0,
"strict": false,
"severityLevel": "DEBUG"
},
"diagnostics": [
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'Fn' of type 'AWS::Serverless::Function' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "Fn",
"entityType": "Resource",
"resourceType": "AWS::Serverless::Function"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 5,
"startColumn": 5,
"endLine": 5,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
}
]
}
}
170 changes: 39 additions & 131 deletions src/resources/expected/validation_reports7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,43 @@
{
"good/sam/function_dlq_valid.yaml": {
"filePath": "good/sam/function_dlq_valid.yaml",
"status": "OK",
"metadata": {
"resourcesScanned": 1,
"counts": {
"fatal": 0,
"errors": 0,
"warnings": 0,
"informational": 1,
"debug": 0
},
"suppressed": 0,
"strict": false,
"severityLevel": "DEBUG"
},
"diagnostics": [
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'Fn' of type 'AWS::Serverless::Function' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "Fn",
"entityType": "Resource",
"resourceType": "AWS::Serverless::Function"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 5,
"startColumn": 5,
"endLine": 5,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
}
]
},
"good/sam/function_image_valid.yaml": {
"filePath": "good/sam/function_image_valid.yaml",
"status": "OK",
Expand Down Expand Up @@ -39176,136 +39215,5 @@
"phase": "LINT"
}
]
},
"quickstart/openshift_master.yaml": {
"filePath": "quickstart/openshift_master.yaml",
"status": "OK",
"metadata": {
"resourcesScanned": 2,
"counts": {
"fatal": 0,
"errors": 0,
"warnings": 0,
"informational": 6,
"debug": 0
},
"suppressed": 0,
"strict": false,
"severityLevel": "DEBUG"
},
"diagnostics": [
{
"ruleId": "I3011",
"severity": "INFO",
"message": "'DeletionPolicy' is a required property (The default action when replacing/removing a resource is to delete it. Set explicit values for stateful resource)",
"source": "CFN_LINT",
"entity": {
"logicalId": "OpenShiftStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"category": "Best Practice",
"startLine": 184,
"startColumn": 3,
"endLine": 184,
"endColumn": 17,
"ruleDescription": "Check stateful resources have a set UpdateReplacePolicy/DeletionPolicy",
"phase": "LINT"
},
{
"ruleId": "I3011",
"severity": "INFO",
"message": "'UpdateReplacePolicy' is a required property (The default action when replacing/removing a resource is to delete it. Set explicit values for stateful resource)",
"source": "CFN_LINT",
"entity": {
"logicalId": "OpenShiftStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"category": "Best Practice",
"startLine": 184,
"startColumn": 3,
"endLine": 184,
"endColumn": 17,
"ruleDescription": "Check stateful resources have a set UpdateReplacePolicy/DeletionPolicy",
"phase": "LINT"
},
{
"ruleId": "I3011",
"severity": "INFO",
"message": "'DeletionPolicy' is a required property (The default action when replacing/removing a resource is to delete it. Set explicit values for stateful resource)",
"source": "CFN_LINT",
"entity": {
"logicalId": "VPCStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"category": "Best Practice",
"startLine": 242,
"startColumn": 3,
"endLine": 242,
"endColumn": 11,
"ruleDescription": "Check stateful resources have a set UpdateReplacePolicy/DeletionPolicy",
"phase": "LINT"
},
{
"ruleId": "I3011",
"severity": "INFO",
"message": "'UpdateReplacePolicy' is a required property (The default action when replacing/removing a resource is to delete it. Set explicit values for stateful resource)",
"source": "CFN_LINT",
"entity": {
"logicalId": "VPCStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"category": "Best Practice",
"startLine": 242,
"startColumn": 3,
"endLine": 242,
"endColumn": 11,
"ruleDescription": "Check stateful resources have a set UpdateReplacePolicy/DeletionPolicy",
"phase": "LINT"
},
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'OpenShiftStack' of type 'AWS::CloudFormation::Stack' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "OpenShiftStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 185,
"startColumn": 5,
"endLine": 185,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
},
{
"ruleId": "I9040",
"severity": "INFO",
"message": "Resource 'VPCStack' of type 'AWS::CloudFormation::Stack' supports Tags but none are configured",
"source": "ENGINE",
"entity": {
"logicalId": "VPCStack",
"entityType": "Resource",
"resourceType": "AWS::CloudFormation::Stack"
},
"propertyPath": "Properties.Tags",
"suggestedFix": "Add Tags to improve resource organization and cost tracking",
"category": "Best Practice",
"startLine": 243,
"startColumn": 5,
"endLine": 243,
"endColumn": 15,
"ruleDescription": "Resource should have Tags",
"phase": "LINT"
}
]
}
}
Loading
Loading