Skip to content

ci: enable Claude PR reviews on this repo - #113

Merged
crowecawcaw merged 1 commit into
aws-deadline:mainlinefrom
crowecawcaw:ci/enable-claude-review
Oct 8, 2026
Merged

crowecawcaw merged 1 commit into
aws-deadline:mainlinefrom
crowecawcaw:ci/enable-claude-review

Conversation

@crowecawcaw

Copy link
Copy Markdown

What was the problem/requirement? (What/Why)

This repo hosts the Claude PR-review workflows, but its own PRs aren't reviewed by them. Changes to the review tooling are exactly the ones where an extra reviewer helps.

What was the solution? (How)

Add the same two thin callers aws-deadline/deadline-cloud uses, copied unchanged except for header comments:

  • claude_pr_review_collect.yml: a no-op stage on pull_request (permissions: {}) whose completion fires workflow_run.
  • claude_pr_review.yml: the review stage on workflow_run. It forwards the trusted head repo and head SHA from the event payload, plus the AWS_CLAUDE_PR_REVIEW_ROLE secret.

Both call this repo's reusable workflows by @mainline, like every other caller. workflow_run also runs from the default branch. So a PR that changes the review workflow is reviewed by the version already on mainline, never by its own copy.

What is the impact of this change?

PRs to this repo get Claude reviews.

Before merging, a repo admin needs to add the AWS_CLAUDE_PR_REVIEW_ROLE repository secret (the same role ARN deadline-cloud uses). Without it, every review run fails at the credentials step. The role's OIDC trust is documented as repo:aws-deadline/*:* with job_workflow_ref pinned to this repo's reusable workflow, which already covers this repo; it's worth confirming.

How was this change tested?

  • zizmor 1.23.1: no findings (the dangerous-triggers ignore is the same as deadline-cloud's). actionlint: clean.
  • The files match deadline-cloud's callers, which run in production, apart from comments.
  • Not run end-to-end: the review can't run until this is merged and the secret exists. The first PR after that is the test.

Was this change documented?

In the workflow header comments.

Is this a breaking change?

No.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add the same two thin callers deadline-cloud uses: a no-op collect workflow on pull_request, and the review workflow on workflow_run, both calling this repo's reusable workflows at @mainline.

Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
@crowecawcaw
crowecawcaw marked this pull request as ready for review October 7, 2026 23:08
@crowecawcaw
crowecawcaw requested a review from a team as a code owner October 7, 2026 23:08

@larrygao001 larrygao001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, a repo admin needs to add the AWS_CLAUDE_PR_REVIEW_ROLE repository secret

Will you follow up on this and confirm it works as it was not tested end to end?

@crowecawcaw
crowecawcaw merged commit 93ccd14 into aws-deadline:mainline Oct 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants