linearize_children: dedup Line refs deterministically - #451
Open
stephane-additive wants to merge 1 commit into
Open
linearize_children: dedup Line refs deterministically#451stephane-additive wants to merge 1 commit into
stephane-additive wants to merge 1 commit into
Conversation
linearize_children uses:
lines = set([w.line for w in words_in_elements])
Line doesn't override __hash__/__eq__, so this set is identity-hashed
and iterates in id()-order — nondeterministic across processes, and
even across repeated allocations in a single process once slots get
recycled. Same Textract JSON can render as different markdown across
runs, which breaks anything downstream that hashes the rendered text.
Replace the set(...) with list(dict.fromkeys(...)) — same dedup, but
iterates in first-occurrence order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`linearize_children` uses:
```python
lines = set([w.line for w in words_in_elements])
```
`Line` doesn't override `hash`/`eq`, so this set is identity-hashed and iterates in `id()`-order — nondeterministic across processes, and even across repeated allocations in a single process once slots get recycled. Same Textract JSON can render as different markdown across runs, which breaks anything downstream that hashes the rendered text.
Fix: `list(dict.fromkeys(...))` — same dedup, first-occurrence order.