Skip to content

feat(gateway): add update commands - #1900

Open
aidandaly24 wants to merge 6 commits into
feat/gateway-create-cudfrom
feat/gateway-update-cud
Open

feat(gateway): add update commands#1900
aidandaly24 wants to merge 6 commits into
feat/gateway-create-cudfrom
feat/gateway-update-cud

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Gateway, Target, connector-backed Target, and Rule update commands
  • support explicit set, clear, and no-op validation semantics
  • GET current Gateway and Target state, merge requested changes, and send the complete replacement requests required by the service
  • keep Rule updates patch-shaped
  • preserve complete API access through JSON sources plus focused MCP endpoint and Connector shortcuts
  • keep Connector shortcut construction handler-owned and Connector classification local to each layer

IAM scope

  • this PR does not create, mutate, or reconcile IAM roles or permission policies
  • --role-arn updates only the Gateway service configuration
  • execution-role permissions remain customer-managed until the shared IAM management plane lands

Stack

Testing

  • focused Gateway validation, flag mapping, request merge, connector classification, and fixture replay tests
  • fixture-backed Gateway, Target, Connector, and Rule updates through the real router and Core
  • full build, lint, formatting, typecheck, cross-platform unit-test, compiled-binary smoke-test, and AgentCore E2E CI coverage

@github-actions github-actions Bot added the size/xl PR size: XL label Aug 4, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 44d48b6 to a7eafd8 Compare August 4, 2026 14:08
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from a7eafd8 to 1fd0230 Compare August 4, 2026 14:22
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 4, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 1fd0230 to c8c57a0 Compare August 4, 2026 16:59
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.39640% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.80%. Comparing base (e932251) to head (f6e7737).

Files with missing lines Patch % Lines
src/handlers/gateway/connector/update/index.tsx 89.26% 16 Missing ⚠️
src/handlers/gateway/rule/update/index.tsx 93.15% 5 Missing ⚠️
src/handlers/gateway/target/update/index.tsx 98.24% 2 Missing ⚠️
src/handlers/gateway/update/index.tsx 99.38% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/gateway-create-cud    #1900      +/-   ##
===========================================================
+ Coverage                    95.77%   95.80%   +0.02%     
===========================================================
  Files                          296      300       +4     
  Lines                        16748    17414     +666     
===========================================================
+ Hits                         16041    16683     +642     
- Misses                         707      731      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from c8c57a0 to 7929436 Compare August 4, 2026 17:57
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 7929436 to 4bc43ed Compare August 4, 2026 18:21
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 4bc43ed to d7e30f7 Compare August 4, 2026 18:32
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 5, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 377f68b to 50e46c5 Compare August 5, 2026 17:48
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 5, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 50e46c5 to 4decb96 Compare August 6, 2026 20:48
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from 8dd4902 to ec74eaf Compare August 6, 2026 22:56
@aidandaly24
aidandaly24 marked this pull request as ready for review August 6, 2026 23:58
@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch 2 times, most recently from 9591e6c to 6e52dff Compare August 7, 2026 15:57
Comment thread src/core/gateway.tsx
Comment on lines +315 to +320
private static isConnectorTarget(configuration: TargetConfiguration | undefined): boolean {
return (
configuration?.mcp?.connector !== undefined ||
configuration?.inference?.connector !== undefined
);
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is also here, but I didn't want to import from the handlers into the core. This avoids circular dependencies.

static is(configuration: TargetConfiguration | undefined): boolean {
return (
configuration?.mcp?.connector !== undefined ||
configuration?.inference?.connector !== undefined
);
}

@aidandaly24
aidandaly24 force-pushed the feat/gateway-update-cud branch from c44a4e5 to f6e7737 Compare August 7, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants