Repository navigation
fix(deploy): synthesize only selected deployment targets - #2590
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agentcore deploy --target devcan fail withCredential "api-key" not found in deployed statebecause the generated CDK app constructs every configured target, including targets whose credentials have not been provisioned.Pass the selected target names to the CDK child process and filter before stack construction. CLI deployment scopes synthesis to its target; interactive deployment preserves the full multi-selection. Standalone CDK synthesis still includes every target. Invalid selections fail before any stack is constructed, and missing credentials on a selected target still fail normally.
Existing generated projects retain their CDK source on upgrade; the configuration guide includes the precise update for their entry point. No construct-package update is required.
Related Issue
Closes #2569.
Documentation PR
Included in
docs/configuration.md.Type of Change
Testing
@aws/agentcore-cdk@0.1.0-alpha.54pass, covering the original failure, API-key/OAuth credentials, multiple selected targets, missing selected credentials, and standalone all-target synthesis. Each generated template contains only its own target's credential ARN.uvprerequisite were resolved by a passing 36-test rerun. Two unrelated tests still fail because their shell commands do not quote checkout paths containing spaces; reproduced on pristine upstream code.No live AWS deployment was performed.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.