Skip to content

fix(harness): increase id validation from 48 char to 51 char #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notgitika merged 1 commit into from
Oct 19, 2026
Merged

fix(harness): increase id validation from 48 char to 51 char #2608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/handlers/harness/delete/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createDeleteHarnessHandler = (core: Core) =>
name: "delete",
description: "delete a harness",
flags: [
flag("id", "the ID of the harness to delete", z.string().min(1).max(48)),
flag("id", "the ID of the harness to delete", z.string().min(1).max(51)),
flag(
"delete-managed-memory",
"whether to also delete the managed Memory (default true; pass false to keep it)",
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/endpoint/create/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createCreateEndpointHandler = (core: Core) =>
name: "create",
description: "create a harness endpoint",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("name", "the name of the endpoint", z.string().min(1)),
flag(
"target-version",
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/endpoint/delete/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createDeleteEndpointHandler = (core: Core) =>
name: "delete",
description: "delete a harness endpoint",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the endpoint name (qualifier)", z.string().min(1)),
],
handle: async (ctx, flags) => {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/endpoint/get/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createGetEndpointHandler = (core: Core) =>
name: "get",
description: "get a harness endpoint",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the endpoint name (qualifier)", z.string().min(1)),
],
handle: async (ctx, flags) => {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/endpoint/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createListEndpointsHandler = (core: Core) =>
name: "list",
description: "list a harness's endpoints",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("next-token", "next token to use on paginated", z.string().optional()),
flag("max-results", "max number of items to return", z.number().optional()),
],
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/endpoint/update/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createUpdateEndpointHandler = (core: Core) =>
name: "update",
description: "update a harness endpoint",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the endpoint name (qualifier)", z.string().min(1)),
flag("target-version", "the harness version the endpoint points to", z.string().optional()),
],
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/exec/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const createExecHarnessHandler = (core: Core, io: AppIO) =>
name: "exec",
description: "run a shell command in a harness",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("command", "the shell command to run", z.string().optional()),
flag(
"session-id",
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/get/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const createGetHarnessHandler = (core: Core) =>
createHandler({
name: "get",
description: "get a harness",
flags: [flag("id", "the ID of the harness", z.string().min(1).max(48))],
flags: [flag("id", "the ID of the harness", z.string().min(1).max(51))],
handle: async (ctx, flags) => {
const harness = await core.harness.getHarness(flags["id"], coreOptsFromCtx(ctx));
ctx.require(JsonRendererKey).renderJson(harness);
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/invoke/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { invokeHarnessTurn } from "./operation.ts";
import { HarnessInvokeLaunchContextKey } from "./launchContext";

export const invokeHarnessFlags = [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("prompt", "the message to send to the harness", z.string().optional()),
flag(
"user-id",
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/logs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { Core } from "../../types";
import { coreOptsFromCtx } from "../../utils";

const harnessFlags = [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the harness endpoint qualifier", z.string().min(1).optional()),
] as const;

Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/shell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const createHarnessShellHandler = (core: Core, io: AppIO) =>
name: "shell",
description: "open an interactive shell in a harness",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the harness endpoint qualifier", z.string().min(1).optional()),
flag("session-id", "the Runtime session ID to use", z.string().min(33).max(256).optional()),
flag("bearer-token", "the CUSTOM_JWT bearer token", z.string().optional(), {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/traces/get/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type { Core } from "../../../types";
import { coreOptsFromCtx } from "../../../utils";

const harnessFlags = [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the harness endpoint qualifier", z.string().min(1).optional()),
] as const;

Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/traces/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { Core } from "../../../types";
import { coreOptsFromCtx } from "../../../utils";

const harnessFlags = [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("qualifier", "the harness endpoint qualifier", z.string().min(1).optional()),
] as const;

Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/update/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const createUpdateHarnessHandler = (core: Core) =>
name: "update",
description: "update a harness (creates a new version)",
flags: [
flag("id", "the ID of the harness to update", z.string().min(1).max(48)),
flag("id", "the ID of the harness to update", z.string().min(1).max(51)),
flag("execution-role-arn", "IAM role the harness assumes", z.string().optional(), {
help: parameterHelp.executionRoleArn,
}),
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/version/get/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createGetVersionHandler = (core: Core) =>
name: "get",
description: "get a specific version of a harness",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("version", "the harness version to get", z.string().min(1)),
],
handle: async (ctx, flags) => {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/harness/version/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const createListVersionsHandler = (core: Core) =>
name: "list",
description: "list a harness's versions",
flags: [
flag("id", "the ID of the harness", z.string().min(1).max(48)),
flag("id", "the ID of the harness", z.string().min(1).max(51)),
flag("next-token", "next token to use on paginated", z.string().optional()),
flag("max-results", "max number of items to return", z.number().optional()),
],
Expand Down
Loading