Repository navigation
fix(e2e): stabilize runtime template tests - #2619
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Narrowly scoped CI/E2E stabilization PR. I checked the three behavior changes:
- Pinning
uvto Python 3.14 matches the comment ("newest Python supported by AgentCore CodeZip") —PYTHON_3_14is the newest value referenced insrc/core/project/runtimeBuild.ts, so this is accurate, and 3.14 is stable upstream. - Per-scenario
--portoffset usesLOCAL_DEV_PORT_BASE + RUNTIME_TEMPLATES.indexOf(runtime). SinceRUNTIME_TEMPLATESis the single post-filterarray shared by every helper, indices are stable per run, and the resulting range (18080..18088) is well above protocol defaults.--portis a real flag onagentcore dev(src/handlers/project/dev/index.ts). scenarioCompletedguard correctly preserves the primary scenario failure: on scenario failure theparseResulton the cleanupdeployis skipped, so the original error propagates out of thetry; on success, cleanup is still validated. The trade-off of silently swallowing a cleanup-only failure when the scenario already failed is the stated intent and is reasonable for afinallyblock.
No test/telemetry concerns — this touches only E2E orchestration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2619 +/- ##
=========================================
Coverage 96.61% 96.61%
=========================================
Files 702 702
Lines 58344 58344
=========================================
Hits 56369 56369
Misses 1975 1975 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes the runtime-template E2E suite across the failures observed in:
The changes:
uvdoes not choose unsupportedCPython 3.15 and attempt native dependency builds on Windows.
port instead of allowing separate
agentcore devprocesses to race for thesame protocol defaults.
that never deployed also fails.
Related Issue
Follow-up to #2605 and the linked failing Actions runs.
Documentation PR
Not applicable; this changes CI and E2E test orchestration only.
Type of Change
Testing
How have you tested the change?
bun test(4,685 passed)bun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.