Bump dependencies: k8s.io v0.35, prometheus v0.311.3, otel v1.42, Go 1.26.3#383
Merged
Conversation
… v0.311.3, otel v1.42, golang.org/x/crypto v0.52, golang.org/x/net v0.55, Go 1.26.3
mitali-salvi
commented
Jun 4, 2026
| } | ||
|
|
||
| func (c CollectorWebhook) Default(ctx context.Context, obj runtime.Object) error { | ||
| otelcol, ok := obj.(*AmazonCloudWatchAgent) |
Contributor
Author
There was a problem hiding this comment.
In controller-runtime v0.23, the webhook interfaces changed from untyped to generic:
- Old: admission.CustomValidator — methods receive runtime.Object, you manually cast and check
- New: admission.Validator[*AmazonCloudWatchAgent] — methods receive *AmazonCloudWatchAgent directly
The type safety that was enforced at runtime with if !ok { return fmt.Errorf(...) } is now enforced at compile time by the generic type parameter.
JayPolanco
previously approved these changes
Jun 4, 2026
movence
previously approved these changes
Jun 4, 2026
JayPolanco
approved these changes
Jun 5, 2026
movence
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps major dependencies to latest compatible versions:
Code Changes
Testing