Add OTEL k8s taints integration tests#706
Open
louisall wants to merge 1 commit into
Open
Conversation
0d91b2d to
2cb3960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds integration tests for the
k8staintsprocessorwhich decorates node telemetry withk8s.node.taint.<key>resource attributes.Tests added
TestTaintsAppearOnDaemonSetMetrics— verifies taint attributes on DaemonSet metrics (local_mode=true)TestTaintsEmptyValueSkipped— verifies empty-value taints are NOT emitted (Granite rejects blank attribute values)TestTaintsAbsentOnUntaintedNodes— verifies untainted nodes have nok8s.node.taint.*attributesTestTaintsAppearOnClusterScraperMetrics— verifies cluster-scraper (local_mode=false) sees taintsTestTaintsMultipleOnSameNode— verifies multiple taints appear together on the same nodeTerraform changes
Adds
null_resource.apply_test_taintsthat applies two test taints (ci-test.example.com/dedicated=gpuandci-test.example.com/team=ml) to the first node in the standard node group before tests run.Dependencies
This PR will not pass CI until the following upstream PRs are merged and deployed:
k8staintsprocessorimplementationk8staintsprocessorincomponents.go+ bumps go.mod SHA (blocked on Integration test for Prometheus EMF Pipeline #509 merging)k8staintsprocessor into all Container Insights pipelinesValidated
All 5 tests pass against a live EKS cluster with a hand-built agent containing the processor.