Consolidate windows tests#709
Open
Paamicky wants to merge 2 commits into
Open
Conversation
009ca97 to
8a7267c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Windows event filtering (event_ID, event_level. regex_filtering) spin up new instances for every test. This introduces unnecessary execution overhead when they can share a single agent configuration and validation pass. This changes merges them together into a single unified test case (windows_events) and reduces test runtime while maintaining the same coverage.
Description of changes
test/feature/windows/event_logs/- basic event level collection testtest/feature/windows/eventid_logs/- event ID filtering testtest/feature/windows/event_regex_logs/- regex include/exclude filter testtest/feature/windows/windows_events/- unified test covering all three scenarios:License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
All previous validation logic (event levels, event IDs, regex filters, file logs) is preserved in the consolidated
parameters.yml. No test coverage is lost.Integration test - All windows test passes: