Skip to content

Consolidate windows tests#709

Open
Paamicky wants to merge 2 commits into
mainfrom
mcommey/windows-test
Open

Consolidate windows tests#709
Paamicky wants to merge 2 commits into
mainfrom
mcommey/windows-test

Conversation

@Paamicky

@Paamicky Paamicky commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description of the issue

Windows event filtering (event_ID, event_level. regex_filtering) spin up new instances for every test. This introduces unnecessary execution overhead when they can share a single agent configuration and validation pass. This changes merges them together into a single unified test case (windows_events) and reduces test runtime while maintaining the same coverage.

Description of changes

  • Removed test/feature/windows/event_logs/ - basic event level collection test
  • Removed test/feature/windows/eventid_logs/ - event ID filtering test
  • Removed test/feature/windows/event_regex_logs/ - regex include/exclude filter test
  • Added test/feature/windows/windows_events/ - unified test covering all three scenarios:
    • Event level-based collection (Security, System, Application)
    • Event ID-based filtering (IDs 400, 700)
    • Regex include/exclude filter collection
    • File log collection (test1.log)

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

All previous validation logic (event levels, event IDs, regex filters, file logs) is preserved in the consolidated parameters.yml. No test coverage is lost.

Integration test - All windows test passes:

@Paamicky Paamicky force-pushed the mcommey/windows-test branch from 009ca97 to 8a7267c Compare June 4, 2026 16:42
@Paamicky Paamicky requested a review from okankoAMZ June 4, 2026 19:19
@Paamicky Paamicky marked this pull request as ready for review June 4, 2026 19:20
@Paamicky Paamicky requested a review from a team as a code owner June 4, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant