feat(otel): Parent Workflow span onto shared execution trace - #647
Draft
ayushiahjolia wants to merge 1 commit into
Draft
feat(otel): Parent Workflow span onto shared execution trace#647ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 20:05 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 20:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 24, 2026 22:15
5c0f1a8 to
95fb7cd
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 22:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 22:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 24, 2026 23:02
95fb7cd to
d97ef9c
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 23:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 23:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 25, 2026 18:08
d97ef9c to
6896e3d
Compare
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 25, 2026 19:36 — with
GitHub Actions
Error
GitHub Actions
Error
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 19:36 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 25, 2026 23:12
338314b to
d226218
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 23:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 25, 2026 23:12 — with
GitHub Actions
Error
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 26, 2026 00:25
d226218 to
c0df70f
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 00:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 00:25 — with
GitHub Actions
Error
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/otel-backend-parented-topology
branch
from
August 26, 2026 06:06
c0df70f to
0ff8de7
Compare
ayushiahjolia
requested a deployment
to
ai-pr-review-runtime
August 26, 2026 06:06 — with
GitHub Actions
In progress
GitHub Actions
In progress
Comment on lines
+26
to
+27
| private static final ContextKey<SamplingResult> KEY = | ||
| ContextKey.named("software.amazon.lambda.durable.otel.durable-sampling-decision"); |
Contributor
There was a problem hiding this comment.
Codex AI review
P1: ContextKey uses reference identity, but the documented ADOT setup loads this JAR separately in the application and Java-agent extension classloaders. The application plugin stores the decision with one KEY, while the agent-loaded DurableSampler reads another, so it always delegates. For example, upstream Sampled=1 with always_off drops every span, contrary to the promised authoritative upstream decision. Bridge the decision across classloaders, analogous to DeterministicIdGenerator's thread-scoped system-property bridge, or use a bootstrap-shared carrier. Add a real dual-classloader test.
| * @param sampling the upstream sampling decision | ||
| */ | ||
| public record ExtractedContext(String traceId, String parentSpanId) {} | ||
| public record ExtractedContext(String traceId, String parentSpanId, Sampling sampling) { |
Contributor
There was a problem hiding this comment.
Codex AI review
P2: The new public canonical constructor accepts a null sampling. This also occurs when Jackson reads legacy two-field serialized values. resolveSamplingResult then switches on null, throwing an exception that PluginRunner swallows and disabling telemetry for the invocation. Add a compact constructor that normalizes null to Sampling.UNDECIDED, and test legacy/missing-field deserialization.
Contributor
Codex AI reviewTwo findings: the ADOT agent path can ignore authoritative sampling decisions, and null sampling values can disable telemetry. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#644
Description
Anchor every durable execution on one trace: the propagated remote server span is the execution ancestor when valid, else a deterministic synthetic root. Workflow and Invocation spans share the trace; sampling follows the header (explicit Sampled preserved, unset deferred to the configured sampler).
Also keep the local test runner's execution ARN stable across reinvocations to match the backend, and pin the OTel conformance workflow to the backend-parented topology assertions.
Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Updated.
Integration Tests
Have integration tests been written for these changes? Added/Updated
Examples
Has a new example been added for the change? (if applicable) N/A