fix(otel): End all recording spans on non-terminal invocations - #650
Draft
ayushiahjolia wants to merge 2 commits into
Draft
fix(otel): End all recording spans on non-terminal invocations#650ayushiahjolia wants to merge 2 commits into
ayushiahjolia wants to merge 2 commits into
Conversation
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 24, 2026 20:29 — with 
GitHub Actions
Error
GitHub Actions
Error
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 20:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Codex AI reviewNo actionable findings. Residual risk: tests were not executed under the read-only review constraints. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#624
Description
Defers Workflow and operation span creation so no recording span is ever left un-ended. Both plugins now hold a deterministic Workflow context between invocations and start+end the Workflow span in a single call on the terminal invocation only. In ExecutionOtelPlugin, operation spans are created once in onOperationEnd (with a start-timestamp fallback for virtual map/parallel operations), and any attempt span still open at invocation end is force-ended. Non-terminal invocations (PENDING/RETRYING) no longer abandon a recording span.
Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Updated
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) N/A