ci: add commit message linting to ci workflow#348
Open
ayushiahjolia wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
Author
|
|
ayushiahjolia
force-pushed
the
ci_linter
branch
2 times, most recently
from
e660273 to
4c897b5
Compare
ayushiahjolia
changed the title
ayushiahjolia
force-pushed
the
ci_linter
branch
3 times, most recently
from
c55fe7d to
7f7fbfa
Compare
yaythomas
requested changes
Apr 24, 2026
ayushiahjolia
force-pushed
the
ci_linter
branch
from
7f7fbfa to
5f2f48c
Compare
zhongkechen
reviewed
Apr 27, 2026
| # | ||
| # To run tests: | ||
| # | ||
| # python -m pytest ops/tests/test_lintcommit.py |
Contributor
There was a problem hiding this comment.
The package name ops is misleading IMO, makes me think this is a SDK operation tool at runtime. We could put these github workflow scripts under .github
Contributor
There was a problem hiding this comment.
And BTW, ci-checks.sh script is broken due to lintcommit.py
# commit message validation
python ops/lintcommit.py
This script should run in hatch's virtualenv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #345
Description of changes:
--rangeflag tolintcommit.pyfor CI to validate commits in a git revision range (e.g.origin/main..<head sha>)lint-commitsCI job that runs onpull_requestevents-z) and--no-mergesinstead of magic string delimiter and merge skip logiclint_range()returningLintResult/CommitResultdataclasses so tests assert on returned data instead of stdout/stderrBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.